[cppyy] Enable tests on windows #18872
Merged
+403
−770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 17h 27m 43s ⏱️ For more details on these failures, see this check. Results for commit 301a63f. ♻️ This comment has been updated with latest results. |
Contributor
2025-05-26T19:53:28.0200811Z 24: if sc == -1:
2025-05-26T19:53:28.0200984Z 24: > raise RuntimeError("Unable to load reflection library "+name)
2025-05-26T19:53:28.0201385Z 24: E RuntimeError: Unable to load reflection library C:\ROOT-CI\build\bindings\pyroot\cppyy\cppyy\test/stltypesDictLooks like we have to use a proper |
guitargeek
force-pushed
the
cppyy-win-tests
branch
2 times, most recently
from
6477723 to
7897153
Compare
guitargeek
force-pushed
the
cppyy-win-tests
branch
from
7897153 to
bff3898
Compare
guitargeek
force-pushed
the
cppyy-win-tests
branch
14 times, most recently
from
1a10344 to
46b7533
Compare
guitargeek
force-pushed
the
cppyy-win-tests
branch
7 times, most recently
from
0ce0043 to
029bbdc
Compare
pcanal
reviewed
Jan 12, 2026
guitargeek
force-pushed
the
cppyy-win-tests
branch
14 times, most recently
from
1bb881f to
207de17
Compare
The `PyObject_CallMethod()` to call `reserve()` might fail, in which case we should not try to decrement the result variable. Use the `Py_XDECREF` macro that does a `nullptr` check.
They are now part of the cppyy tests that are run on all platforms. The only test that is kept is a ROOT-specific one, which is moved to a different file.
Most tests were already present in the cppyy test suite, except for the `std::tuple_element` test introduced in the following commit: root-project/roottest@c0e6d20
We should be more granular and consistent when disabling tests.
guitargeek
force-pushed
the
cppyy-win-tests
branch
from
207de17 to
67495c2
Compare
guitargeek
approved these changes
Jan 15, 2026
Contributor
There was a problem hiding this comment.
Thank you very much! I made some additional changes to bring the PR over the finish line:
- use ACLiC for dictionary generation, which worked the easiest on all platforms (as was done by the old
roottest/python) - remove some tests in
roottest/pythonthat are redundant, now that we also run the cppyy tests on all platforms - consistently use the pytest markers to steer disabling of tests. This gives us a better overview of what is actually disabled, and lets us do more granular disabling
- temporarily circumvent a crash on Windows 64 bit by replacing a
Py_DECREFwithPy_XDECREF, which includes anullptrprotection (FYI, @bellenot).
Note that some incremental builds might fail in the next hours, because some declarations will be available both in the old test dictionaries generated by ROOT_GENERATE_DICTIONARY, and the new ones generated by ACLiC. The declarations might clash and cause test failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger a verbose CI run with Windows to examine the cppyy test status